Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(glue): synth time validation does not work in Python/Java/C#/Go #26650

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

lpizzinidev
Copy link
Contributor

Fixes some issues on Glue Job synth time validation:

  • maxCapacity can be specified for PythonShell jobs with Glue Version 2.0+ and should be either 0.0625 or 1 (defaults to 0.0625)
  • Validation was not working when using GlueVersion.of() and JobType.of()
  • PythonShell jobs supports GlueVersion 3.0

Closes #26620.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Aug 7, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 7, 2023 07:27
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3dcbbb9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 7, 2023
@rix0rrr rix0rrr changed the title fix(glue-alpha): fixed Glue Job synth time validation checks fix(glue): synth time validation does not work in Python/Java/C#/Go Aug 7, 2023
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 7, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit dba8cf3 into aws:main Aug 7, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(glue-alpha): Improve Glue version synth time checks
3 participants