fix(custom-resources): incorrect sdkv3 fallback #26693
Conversation
Fixes logic within the aws-sdk-v3-handler for AwsCustomResource to behave more like the v2 handler, in so much as if `installLatestSdk` fails, but it can still require the package it was attempting to install, it will continue. This makes the runtime more friendly to deploying your constructs across regions that may or may not have access to npm within the lambda runtime.
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
kaizencc
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Fixes logic within the aws-sdk-v3-handler for AwsCustomResource to
behave more like the v2 handler, in so much as if
installLatestSdkfails, but it can still require the package it was attempting to
install, it will continue.
This makes the runtime more friendly to deploying your constructs across
regions that may or may not have access to npm within the lambda
runtime.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license