-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(glue): Job construct does not honor SparkUIProps S3 prefix when granting S3 access #26696
Conversation
I did not include an integ test since Spark did not write to s3 even when enabled (for a trivial script). Non trivial scripts usually failed since we did not have the set up for them, or Spark did not write anything. I verified that the set up in the console is correct, but could not get anything to be written by Spark through manual testing. Since this is an alpha module (and this issue has gotten very little attention), I think it is fine to wait to add the integ test until a user either says this does not work or provides a script that shows Spark writing logs. There is already an integ test that has Spark enabled, so there is almost no value add for an additional test with the prefix set up, since it is currently functionally the same. (If we feel strongly that we need one, I have one written and can throw it in!) |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The
SparkUIProps.prefix
attribute ofglue.Job
now has a consistent format, is validated, and the bucket ReadWrite role is only given permissions to the folder of the bucket specified by theprefix
if provided.Adds a suggested format for the prefix:
/foo/bar
and throws and error if the prefix does not start with a/
or ends without a/
.This may be a breaking change for users who configured their prefix in a style different than this enforces. However, I believe it is the correct standardization going forward.
Closes #19862.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license