Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-cdk-lib): custom resources using Node16 and SDKv2 #26710

Merged
merged 8 commits into from
Aug 11, 2023
Merged

Conversation

MrArnoldPalmer
Copy link
Contributor

Changes the IAM OIDC provider custom resource to use Node18 and SDKv3.

Changes the restrict-default-security-group custom resource to use
Node18 and sdkv3. Updates unit tests to use the mock client library for
easier mocking.

deployed integration test stacks for testing.

Closes #26708


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Changes the IAM OIDC provider custom resource to use Node18 and SDKv3.

Ran integ test to ensure functionality is preserved.
Changes the restrict-default-security-group custom resource to use
Node18 and sdkv3. Updates unit tests to use the mock client library for
easier mocking.

deployed integration test stacks for testing.
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Aug 10, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 10, 2023 20:33
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 10, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@MrArnoldPalmer MrArnoldPalmer changed the title fix(iam,ec2): custom resources using Node16 and SDKv2 fix(aws-cdk-lib): custom resources using Node16 and SDKv2 Aug 10, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 10, 2023 20:43

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Aug 11, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ed52847
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 259a469 into main Aug 11, 2023
9 checks passed
@mergify mergify bot deleted the fix/26708 branch August 11, 2023 17:59
@mergify
Copy link
Contributor

mergify bot commented Aug 11, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(ec2/iam): custom resources using Node16/SdkV2
3 participants