Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk): enable hotswap for appsync function and resolver code #26725

Closed
wants to merge 8 commits into from

Conversation

onlybakam
Copy link
Contributor

Update the hotswap feature for AppSync resolvers and functions to include the code attribute. Currently hotswap only works for mapping templates. With the introduction of JavaScript support in AppSync, developers use the code attribute to set their JavaScript code.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Aug 11, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 11, 2023 17:36
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Aug 11, 2023
@onlybakam onlybakam changed the title feat(aws-cdk): enable hotswap for AppSync function and resolver code feat(aws-cdk): enable hotswap for appsync function and resolver code Aug 11, 2023
@onlybakam onlybakam changed the title feat(aws-cdk): enable hotswap for appsync function and resolver code feat(cdk): enable hotswap for appsync function and resolver code Aug 11, 2023
Copy link
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good overall, but it needs unit tests. Please add tests that verify:

  1. The requestMappingTemplate and responseMappingTemplate are not passed to the updateFunction SDK call when Code is specified.
  2. The code is not passed to updateFunction when either requestMappingTemplate / responseMappingTemplate are specified
  3. The code is passed to updateFunction when specified.

@comcalvi comcalvi added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Aug 14, 2023
fix typo

Co-authored-by: Calvin Combs <66279577+comcalvi@users.noreply.github.com>
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 85da1a2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Sep 13, 2023
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/26725/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2 pr/needs-cli-test-run This PR needs CLI tests run against it. pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants