-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdk): enable hotswap for appsync function and resolver code #26725
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good overall, but it needs unit tests. Please add tests that verify:
- The
requestMappingTemplate
andresponseMappingTemplate
are not passed to theupdateFunction
SDK call whenCode
is specified. - The
code
is not passed toupdateFunction
when eitherrequestMappingTemplate
/responseMappingTemplate
are specified - The
code
is passed toupdateFunction
when specified.
fix typo Co-authored-by: Calvin Combs <66279577+comcalvi@users.noreply.github.com>
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Update the hotswap feature for AppSync resolvers and functions to include the
code
attribute. Currently hotswap only works for mapping templates. With the introduction of JavaScript support in AppSync, developers use thecode
attribute to set their JavaScript code.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license