-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ec2): add M7gd, R7gd, C7gd instance types #26776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
136e4dd
to
98f39b9
Compare
98f39b9
to
e967487
Compare
The instance type enum and map currently exclude the x7GD subfamily of instance types.
46a356e
to
4707c8b
Compare
Clarification Request. Current documentation / integration tests do not seem to specifically test the 'd' subfamily of instance types. A codebase search for '6gd' shows only documentation related to ElasticSearch and ElastiCache, which should be updated when the respective services update to support this instance type instead of when the instance types become selectable for general EC2 provisioning. It is unclear where a README or which Integration Tests would be updated to reflect availability of these new instance types. Should this be categorized as something other than feat, or just subject to a manual review to bypass the automated PR checks since they do not seem to apply fully here? Modeled after #12301 |
@funguy-tech Thanks for working on this. I updated the title to be a chore. I found a similar PR (#24450) that we can model this after. That said, we don't need an integ test or a README update for this. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@funguy-tech Looks good. Thanks for adding these!
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
As of v2.92.0, we don't yet have C7gd, M7gd, and R7gd instance types available via instance type selection.
Closes #26774
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license