Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(iot): fix CloudWatch Metric example #26784

Merged
merged 2 commits into from
Aug 17, 2023
Merged

docs(iot): fix CloudWatch Metric example #26784

merged 2 commits into from
Aug 17, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Aug 17, 2023

This example gets replicated to the CloudWatch Metrics documentation, where it is wrong.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This example gets replicated to the CloudWatch Metrics documentation, where it is wrong.
@rix0rrr rix0rrr requested a review from a team August 17, 2023 08:27
@github-actions github-actions bot added the p2 label Aug 17, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 17, 2023 08:27
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 17, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 17, 2023
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked to make sure that dimensions exists but is deprecated, which is why rosetta did not catch this

@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 17, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1ca9072
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ecb34bb into main Aug 17, 2023
11 checks passed
@mergify mergify bot deleted the rix0rrr-patch-1 branch August 17, 2023 14:21
@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants