Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CLI): diff reports wrong count of changed stacks #26796

Merged
merged 7 commits into from
Aug 21, 2023
Merged

fix(CLI): diff reports wrong count of changed stacks #26796

merged 7 commits into from
Aug 21, 2023

Conversation

comcalvi
Copy link
Contributor

@comcalvi comcalvi commented Aug 17, 2023

The current logic counts the number of changes in any parent stacks. It doesn't count nested stacks correctly, and doesn't count parent stacks correctly.

With this change:
Screenshot 2023-08-18 at 9 43 49 AM

Without this change:
Screenshot 2023-08-18 at 9 51 55 AM

Closes #26818.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Aug 17, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 17, 2023 20:35
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 17, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Aug 17, 2023
@comcalvi comcalvi marked this pull request as ready for review August 18, 2023 16:52
@comcalvi comcalvi changed the title fix(CLI): diff reports number of resource changes but labels them stack changes fix(CLI): diff reports wrong count of changed stacks Aug 18, 2023
@comcalvi comcalvi added p1 and removed p2 labels Aug 18, 2023
@rix0rrr rix0rrr added pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested labels Aug 21, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 21, 2023 09:48

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-cli-test-run This PR needs CLI tests run against it. label Aug 21, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort labels Aug 21, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f5566ba
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 26dcc1e into main Aug 21, 2023
8 of 9 checks passed
@mergify mergify bot deleted the stackdiffs branch August 21, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p1 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Number of stacks with differences" is wrong
3 participants