Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-python): poetry bundling is broken after Aug 20 #26823

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Aug 21, 2023

The Dockerfile that builds an executable container to run poetry in installs the latest version of poetry on a Python 3.7 Docker image.

Unfortunately poetry 1.6.0, released August 20, drops support for Python 3.7 which means that all poetry bundling jobs started failing on that date. 1.6.0 also does not work on Python 3.8, which I don't see mentioned in the change log, but our integration tests that use Python 3.8 are also broken.

Lock the poetry version back to 1.5.1 by using a version specifier so the command is not dependent on the date it is run.

This is the last version that supported both Python 3.7 and 3.8.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The Dockerfile that builds an executable container to run `poetry` in
installs the latest version of `poetry` on a Python 3.7 Docker image.

Unfortunately `poetry 1.6.0`, released August 20, drops support for
Python 3.7 which means that all poetry bundling jobs started failing
on that date.

Upgrade to a base image of Python 3.9 to make the newest poetry work,
and lock the poetry version in place by using a version specifier
so the command is not dependent on the date it is run.
@rix0rrr rix0rrr requested a review from a team August 21, 2023 12:49
@aws-cdk-automation aws-cdk-automation requested a review from a team August 21, 2023 12:49
@github-actions github-actions bot added the p2 label Aug 21, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 21, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@rix0rrr rix0rrr changed the title fix(aws-lambda-python): poetry bundling is broken after Aug 20 fix(lambda-python): poetry bundling is broken after Aug 20 Aug 21, 2023
@rix0rrr rix0rrr added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Aug 21, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 21, 2023 12:54

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 801025f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 95f8cef into main Aug 21, 2023
10 checks passed
@mergify mergify bot deleted the huijbers/poetry-version branch August 21, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants