fix(route53): IHostedZone cannot be used for ses.Identity.publicHostedZone anymore #26888
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identity.publicHostedZone
takes anIPublicHostedZone
, but because of TypeScript structural typing it would also accept anIHostedZone
.When in this PR the
grantDelegation
method was added to theIPublicHostedZone
interface, this passing was no longer allowed and code that used to work on accident, no longer works.For example:
It raises an error because the imported
zone
does not implement thegrantDelegation
method.This fix moves the
grantDelegation
method declaration into theIHostedZone
interface and makes it available to all imported zones.Closes #26872.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license