Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda): update default runtimes and tests to node 18 #27066

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Sep 8, 2023

Upgrades remaining runtime versions from NODEJS_16_X (which enters EOL on 2023-09-11 and will enter Lambda's Deprecation Phase 1 on Mar 11 2024) to NODEJS_18_X.

Also updates remaining unit & integration tests to use NODEJS_LATEST or NODEJS_18_X.
Most tests will reference the lambda runtime version via a new centralized configuration.
Updated a number of test handlers to use SDKv3 and cleaned-up some duplicated, unused handler files.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Sep 8, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 8, 2023 13:43
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 8, 2023
@mrgrain mrgrain force-pushed the mrgrain/chore/node-18-everywhere branch from d23ff20 to ad47acb Compare September 11, 2023 11:19
@mrgrain mrgrain force-pushed the mrgrain/chore/node-18-everywhere branch from ad47acb to b327cac Compare September 11, 2023 12:05
@mrgrain mrgrain self-assigned this Sep 11, 2023
@mrgrain mrgrain marked this pull request as ready for review September 11, 2023 16:59
@mrgrain mrgrain force-pushed the mrgrain/chore/node-18-everywhere branch 2 times, most recently from 9f77fff to 86fe5e1 Compare September 11, 2023 17:59
@mrgrain mrgrain force-pushed the mrgrain/chore/node-18-everywhere branch from 86fe5e1 to d8404d1 Compare September 11, 2023 19:07
@mrgrain mrgrain temporarily deployed to test-pipeline September 11, 2023 19:08 — with GitHub Actions Inactive
@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d8404d1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 11, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 04b30f3 into main Sep 11, 2023
12 checks passed
@mergify mergify bot deleted the mrgrain/chore/node-18-everywhere branch September 11, 2023 20:12
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 11, 2023
mikewrighton pushed a commit that referenced this pull request Sep 14, 2023
Upgrades remaining runtime versions from `NODEJS_16_X` (which enters EOL on 2023-09-11 and will enter Lambda's Deprecation Phase 1 on Mar 11 2024) to NODEJS_18_X.

Also updates remaining unit & integration tests to use NODEJS_LATEST or NODEJS_18_X.
Most tests will reference the lambda runtime version via a new centralized configuration.
Updated a number of test handlers to use SDKv3 and cleaned-up some duplicated, unused handler files.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants