Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(amplify): missing integ test for AWS Amplify #27107

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

SankyRed
Copy link
Contributor

Adding an integ test for this custom resource with our new rule that each custom resource needs at least one integ test. Adding this test for the custom resource to test out AWS Amplify app.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Sep 11, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 11, 2023 23:10
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 11, 2023
@SankyRed SankyRed marked this pull request as ready for review September 12, 2023 00:38
@mrgrain mrgrain changed the title chore(amplify): Adding integ test for AWS Amplify chore(amplify): add missing integ test for AWS Amplify Sep 12, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 12, 2023
@SankyRed SankyRed force-pushed the SankyRed/amplify-alpha-integ-test branch from 52fcd45 to ae435e4 Compare September 12, 2023 13:04
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditionally approved - would like to see some additional documentation convincing me that this tests the 2 custom resources in amplify.

@kaizencc kaizencc added the pr/do-not-merge This PR should not be merged at this time. label Sep 12, 2023
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 12, 2023
@SankyRed SankyRed force-pushed the SankyRed/amplify-alpha-integ-test branch from a5bb3dc to 99a8a9f Compare September 12, 2023 14:09
@SankyRed SankyRed removed the pr/do-not-merge This PR should not be merged at this time. label Sep 12, 2023
@kaizencc kaizencc changed the title chore(amplify): add missing integ test for AWS Amplify chore(amplify): missing integ test for AWS Amplify Sep 12, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 99a8a9f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 480b1f5 into main Sep 12, 2023
17 checks passed
@mergify mergify bot deleted the SankyRed/amplify-alpha-integ-test branch September 12, 2023 14:34
mikewrighton pushed a commit that referenced this pull request Sep 14, 2023
Adding an integ test for this custom resource with our new rule that each custom resource needs at least one integ test. Adding this test for the custom resource to test out AWS Amplify app.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants