Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(custom-resources): does not accept strings where numbers are expected, skips recursive types #27112

Merged
merged 11 commits into from
Sep 14, 2023
Merged

fix(custom-resources): does not accept strings where numbers are expected, skips recursive types #27112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8dbd788
chore(scripts): Add a new type coercion map for numeric types
otaviomacedo Sep 12, 2023
7e750f2
Generating a JSON file instead of TypeScript file, so we can gzip and…
otaviomacedo Sep 12, 2023
d99568e
Consuming the new map from a JSON file, and applying the number coerc…
otaviomacedo Sep 13, 2023
2c793a1
Using require instead of import for the JSON file
otaviomacedo Sep 13, 2023
1bb4cbd
Increased memory size to 256
otaviomacedo Sep 13, 2023
accd907
Updated snapshots
otaviomacedo Sep 14, 2023
43c615a
Support recursive types
rix0rrr Sep 14, 2023
e5a17a6
Remove updated line from shell script
rix0rrr Sep 14, 2023
e1404b1
Snapshots
rix0rrr Sep 14, 2023
d0ea654
Merge branch 'otaviom/number-parameters' of github.com:aws/aws-cdk in…
rix0rrr Sep 14, 2023
083780b
Merge remote-tracking branch 'origin/main' into otaviom/number-parame…
rix0rrr Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 0 additions & 1 deletion ....snapshot/asset.51fc32183f8be2ed4acc5164067a61d6763acbd372aeba432deb95b9ac5b5038/index.js
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions ....snapshot/asset.e5178afc49b7c6a85127a67856ce958e4f0879ce6aad5e974cac2a088bf939db/index.js
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions ...t/lambda/integ.deployment-config.js.snapshot/aws-cdk-codedeploy-lambda-config.assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,28 @@
{
"version": "34.0.0",
"files": {
"51fc32183f8be2ed4acc5164067a61d6763acbd372aeba432deb95b9ac5b5038": {
"e5178afc49b7c6a85127a67856ce958e4f0879ce6aad5e974cac2a088bf939db": {
"source": {
"path": "asset.51fc32183f8be2ed4acc5164067a61d6763acbd372aeba432deb95b9ac5b5038",
"path": "asset.e5178afc49b7c6a85127a67856ce958e4f0879ce6aad5e974cac2a088bf939db",
"packaging": "zip"
},
"destinations": {
"current_account-current_region": {
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
"objectKey": "51fc32183f8be2ed4acc5164067a61d6763acbd372aeba432deb95b9ac5b5038.zip",
"objectKey": "e5178afc49b7c6a85127a67856ce958e4f0879ce6aad5e974cac2a088bf939db.zip",
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
}
}
},
"16fed48cbbc3528cf00b892da3cd8fe72007a0ef4c7adff2fd8fdfb9c7bf0d5d": {
"9fe810257cfcfa9ad36b78a24f4bde21cc92a5fbc22ce909ea3b65b8244fda08": {
"source": {
"path": "aws-cdk-codedeploy-lambda-config.template.json",
"packaging": "file"
},
"destinations": {
"current_account-current_region": {
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
"objectKey": "16fed48cbbc3528cf00b892da3cd8fe72007a0ef4c7adff2fd8fdfb9c7bf0d5d.json",
"objectKey": "9fe810257cfcfa9ad36b78a24f4bde21cc92a5fbc22ce909ea3b65b8244fda08.json",
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
}
}
Expand Down
3 changes: 2 additions & 1 deletion ...lambda/integ.deployment-config.js.snapshot/aws-cdk-codedeploy-lambda-config.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,10 @@
"S3Bucket": {
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
},
"S3Key": "51fc32183f8be2ed4acc5164067a61d6763acbd372aeba432deb95b9ac5b5038.zip"
"S3Key": "e5178afc49b7c6a85127a67856ce958e4f0879ce6aad5e974cac2a088bf939db.zip"
},
"Handler": "index.handler",
"MemorySize": 256,
"Role": {
"Fn::GetAtt": [
"AWS679f53fac002430cb0da5b7982bd2287ServiceRoleC1EA0FF2",
Expand Down
2 changes: 1 addition & 1 deletion ...k-integ/test/aws-codedeploy/test/lambda/integ.deployment-config.js.snapshot/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"validateOnSynth": false,
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-deploy-role-${AWS::AccountId}-${AWS::Region}",
"cloudFormationExecutionRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-cfn-exec-role-${AWS::AccountId}-${AWS::Region}",
"stackTemplateAssetObjectUrl": "s3://cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}/16fed48cbbc3528cf00b892da3cd8fe72007a0ef4c7adff2fd8fdfb9c7bf0d5d.json",
"stackTemplateAssetObjectUrl": "s3://cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}/9fe810257cfcfa9ad36b78a24f4bde21cc92a5fbc22ce909ea3b65b8244fda08.json",
"requiresBootstrapStackVersion": 6,
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version",
"additionalDependencies": [
Expand Down
3 changes: 2 additions & 1 deletion ...ework-integ/test/aws-codedeploy/test/lambda/integ.deployment-config.js.snapshot/tree.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,9 +224,10 @@
"s3Bucket": {
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
},
"s3Key": "51fc32183f8be2ed4acc5164067a61d6763acbd372aeba432deb95b9ac5b5038.zip"
"s3Key": "e5178afc49b7c6a85127a67856ce958e4f0879ce6aad5e974cac2a088bf939db.zip"
},
"handler": "index.handler",
"memorySize": 256,
"role": {
"Fn::GetAtt": [
"AWS679f53fac002430cb0da5b7982bd2287ServiceRoleC1EA0FF2",
Expand Down
161 changes: 0 additions & 161 deletions ...9f77d2e9161f4799d4facb1cb8859134a40234014484b4911e924c169c9cb/aws-sdk-v2-handler/index.js
View file
Open in desktop

This file was deleted.

139 changes: 0 additions & 139 deletions ...9f77d2e9161f4799d4facb1cb8859134a40234014484b4911e924c169c9cb/aws-sdk-v3-handler/index.js
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions ...cb1cb8859134a40234014484b4911e924c169c9cb/aws-sdk-v3-handler/v2-to-v3/client-names-map.js
View file
Open in desktop

This file was deleted.

Loading