-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(integ-tests): cannot make two or more identical assertions #27380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, thanks! 💪
Just a typo and a missing test case and it will be good to go for me.
packages/@aws-cdk/integ-tests-alpha/test/assertions/deploy-assert.test.ts
Show resolved
Hide resolved
packages/@aws-cdk/integ-tests-alpha/test/assertions/deploy-assert.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/integ-tests-alpha/test/assertions/deploy-assert.test.ts
Outdated
Show resolved
Hide resolved
@lpizzinidev Thanks for your review! I believe I've made all the requested adjustments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks 👍
Pull request has been modified.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This PR resolves errors in the integration test library when users run identical assertions multiple times.
This change ensures that each use of
awsApiCall
,httpApiCall
, andinvokeFunction
has a unique identifier, even when multiple identical assertions are used in the same context. We introduced auniqueAssertionId
function in theDeployAssert
construct that maintains backward compatibility with the old id rendering scheme, but prevents the use of conflicting construct ids by tracking the usage of ids and differentiating them where there's a conflict.Closes #22043, #23049
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license