Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks): added support for EKS version 1.28 #27502

Closed
wants to merge 7 commits into from

Conversation

khushail
Copy link
Contributor

Similar to this (#25897), added support for EKS 1.28

Resolves (#27500)


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Oct 11, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team October 11, 2023 21:05
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@cristianmagana
Copy link

@khushail was there an eta for this? Would be interested in contributing if possible.

@endersonmaia
Copy link

I assume this PR depends on that: cdklabs/awscdk-asset-kubectl#450

@khushail
Copy link
Contributor Author

@endersonmaia ,your assumption is correct.
@cristianmagana , I am done with my PR but would need this PR to be merged before that.

@pahud
Copy link
Contributor

pahud commented Oct 26, 2023

cdklabs/awscdk-asset-kubectl#450 it's merged!

@gkaskonas
Copy link
Contributor

@khushail Can you fix the PR please

@dougalrea
Copy link

Is there anything else blocking this? Would be great to get 1.28 support in CDK for those of us needing to migrate away from soon-to-be deprecated versions

@khushail khushail changed the title feat(eks):added support for EKS version 1.28 feat(eks): added support for EKS version 1.28 Nov 1, 2023
@khushail
Copy link
Contributor Author

khushail commented Nov 1, 2023

Exemption Request

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Nov 1, 2023
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@michelesr
Copy link

If you don't want to be blocked on this you can use KubernetesVersion.of("1.28") in your project, and update the kubectl layer, to move your cluster to 1.28.

@sumupitchayan
Copy link
Contributor

@khushail can you figure out how to get the build to succeed? Looks like maybe the import statements might be incorrect?

@khushail
Copy link
Contributor Author

khushail commented Nov 7, 2023

@khushail can you figure out how to get the build to succeed? Looks like maybe the import statements might be incorrect?

Sure, I will take a look.

@sumupitchayan sumupitchayan self-assigned this Nov 8, 2023
@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Nov 9, 2023
@khushail khushail reopened this Nov 9, 2023
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to a test file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3ca3987
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants