-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(glue-alpha): add cfn-glue-table-tableinput-parameters
to Glue table construct
#27643
feat(glue-alpha): add cfn-glue-table-tableinput-parameters
to Glue table construct
#27643
Conversation
Note: On current glue-alpha, |
It seems integration test failed on CodeBuild. I'll check Build Logs.
|
I have resolved some issues. I would appreciate it if you could review it. |
Hey @lawofcycles , apologies for the delay and thank you for opening a contribution with us. I will review this PR soon. |
Awaiting @TheRealAmazonKendra review on the PR. |
Any chance to have it reviewed quickly : this is a issue that avoid us to push S3Table in CI/CD to production : no access to change CloudFormation template in production environment |
FYI: we're in the process of revamping the glue module, which is why I haven't been approving any glue PRs lately. Please bear with us a bit longer, I'm trying to see if we can get the green light to continue to merge quality-of-life PRs in the meantime. |
Per Kendra's request, I reviewed these changes and can confirm that these changes do not conflict with the glue-alpha L2 work in flight. Safe to merge pending all other CDK service team checks without impacting our work. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@Mergifyio update |
❌ Mergify doesn't have permission to updateFor security reasons, Mergify can't update this pull request. Try updating locally. |
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
…table construct (aws#27643) Add [cfn-glue-table-tableinput-parameters](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-glue-table-tableinput.html#cfn-glue-table-tableinput-parameters) to Glue Table construct as optional props User can specify additional table parameter when creating Glue Table. Any key/value can be set depending on each user's requirement like table's additional metadata or statistics. Some parameter can be used when AWS services / 3rd party tools read table like `skip.header.line.count`. Closes aws#14159. --- All Submissions: - [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) Adding new Unconventional Dependencies: - [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) New Features - [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? - [x] Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)? --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Co-authored-by: Vinayak Kukreja <78971045+vinayak-kukreja@users.noreply.github.com> Co-authored-by: Sumu Pitchayan <35242245+sumupitchayan@users.noreply.github.com>
Add cfn-glue-table-tableinput-parameters to Glue Table construct as optional props
User can specify additional table parameter when creating Glue Table.
Any key/value can be set depending on each user's requirement like table's additional metadata or statistics. Some parameter can be used when AWS services / 3rd party tools read table like
skip.header.line.count
.Closes #14159.
All Submissions:
Adding new Unconventional Dependencies:
New Features
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license