-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(codepipeline-actions): default branch for CodeCommit is master (under feature flag) #27753
fix(codepipeline-actions): default branch for CodeCommit is master (under feature flag) #27753
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request: I ran the integration tests and the snapshots have been changed. So I think a new integration test is not needed. |
I am not sure but wouldn't this probably need a feature flag? Since a user may have deployed when the default was |
@kylelaker Thanks for the feedback. :) I think you are right - it would make sense to introduce a feature flag here. I'll try to implement this. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Will approve once the build is fixed. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Closes #27710.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license