Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(prlint): don't mark PRs as 'not ready' on community comment #27819

Merged
merged 3 commits into from
Nov 8, 2023

Commits on Nov 3, 2023

  1. chore(prlint): don't mark PRs as 'not ready' on community comment

    Community reviewers have the ability to choose any of the
    approve/comment/request changes buttons that are available in the review
    tab. Prior to this change, `prlint` would consider a comment from a
    community reviewer as being equivalent to requesting changes (and in
    fact, didn't consider the requesting changes case). This would remove
    the `pr/needs-community-review` label which surprised some reviewers.
    
    With this change, `prlint` will only remove the
    `pr/needs-community-review` label when a community reviewer specifically
    chooses "request changes". Additionally, reviewers are now able to
    switch from approving to requesting changes (this doesn't override any
    other reviewers' approvals, just that reviewer's own).
    
    Additionally, this adds mocks for the `getTrustedCommunityMembers`
    method and avoids hardcoding the logins of multiple community reviewers
    into the tests. As a side effect, the tests also run faster since `curl`
    isn't being invoked so frequently.
    laurelmay committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    1e24d2e View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Configuration menu
    Copy the full SHA
    c0a8b1a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e67e5f9 View commit details
    Browse the repository at this point in the history