Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): fix ecs hotswap deployment waiting conditions #27943

Closed
wants to merge 10 commits into from
Closed

fix(cli): fix ecs hotswap deployment waiting conditions #27943

wants to merge 10 commits into from

Commits on Dec 9, 2023

  1. test: add hotswap ecs integration test

    @tomwwright
    tomwwright committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    b976bb6 View commit details
    Browse the repository at this point in the history

  2. test: add integ test for waiting on ecs hotswap

    @tomwwright
    tomwwright committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    305cb4d View commit details
    Browse the repository at this point in the history

  3. fix: improve deployment completion checking 

    new deployments are initially in an intermediate state with 0 counts which the waiter may match and return on immediately

this uses a more reliable property that signals deployment completion
    @tomwwright
    tomwwright committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    eb1546f View commit details
    Browse the repository at this point in the history

  4. fix: reverse logic to support multiple services

    @tomwwright
    tomwwright committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    f2c0917 View commit details
    Browse the repository at this point in the history

  5. fix: failure and non-rolling update waiter conditions

    @tomwwright
    tomwwright committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    968d019 View commit details
    Browse the repository at this point in the history

  6. refactor: rename custom waiter for clearer error message

    @tomwwright
    tomwwright committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    f6efffb View commit details
    Browse the repository at this point in the history

  7. test: integ test for failed ecs hotswap

    @tomwwright
    tomwwright committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    ea9e0eb View commit details
    Browse the repository at this point in the history

  8. test: improve speed of ecs integration tests

    @tomwwright
    tomwwright committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    e7b7f14 View commit details
    Browse the repository at this point in the history

  9. fix: faster polling for ecs hotswap 

    the FAILED intermediate state is short

faster polling ensures responsive deployments
    @tomwwright
    tomwwright committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    dfbe48e View commit details
    Browse the repository at this point in the history

  10. fix: simplify waiter conditions

    @tomwwright
    tomwwright committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    ad6d8c9 View commit details
    Browse the repository at this point in the history