Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 2.108.1 #27992

Merged
merged 4 commits into from
Nov 14, 2023
Merged

chore(release): 2.108.1 #27992

merged 4 commits into from
Nov 14, 2023

Conversation

kaizencc
Copy link
Contributor

See CHANGELOG.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

lpizzinidev and others added 3 commits November 14, 2023 13:10
…27948)

#27558 fixed a circular dependency issue between the bucket and the ELB when using `logAccessLogs` by adding the dependency at the L1 level.
The dependency was added on both the bucket and the bucket policy (which already refers to the bucket).

This introduced a new bug when adding a dependency for imported buckets (as `bucket.node.defaultChild` is `undefined`).

This PR fixes the issue by adding the dependency at the L1 level on the bucket policy directly.

Closes #27928.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@kaizencc kaizencc added the pr/no-squash This PR should be merged instead of squash-merging it label Nov 14, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team November 14, 2023 18:15
@github-actions github-actions bot added the p2 label Nov 14, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 14, 2023
@MrArnoldPalmer MrArnoldPalmer added the pr/do-not-merge This PR should not be merged at this time. label Nov 14, 2023
Copy link
Contributor

@MrArnoldPalmer MrArnoldPalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the alpha CL, added do not merge so be sure to remove once done.

CHANGELOG.v2.alpha.md Outdated Show resolved Hide resolved
Co-authored-by: Mitchell Valine <mitchellvaline@yahoo.com>
@kaizencc kaizencc removed the pr/do-not-merge This PR should not be merged at this time. label Nov 14, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b1bf06f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Nov 14, 2023

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2320255 into v2-release Nov 14, 2023
13 of 14 checks passed
@mergify mergify bot deleted the patch/v2.108.1 branch November 14, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr/no-squash This PR should be merged instead of squash-merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants