-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloudfront): CloudFront Function runtime property #28099
Merged
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
28ab0c3
feat(cloudfront): Setting Runtime of CF2
watany-dev 9f54b1c
readme
watany-dev 8673979
integ
watany-dev 757a212
snapshot
watany-dev d3fb723
Revert "snapshot"
watany-dev 0b165cd
integ
watany-dev 858e821
Merge branch 'main' into cf2-runtime2
watany-dev c209632
fix readme
watany-dev a74e730
Merge branch 'cf2-runtime2' of https://github.com/watany-dev/aws-cdk …
watany-dev e80fa76
Merge branch 'aws:main' into cf2-runtime2
watany-dev 204bfe4
Merge branch 'aws:main' into cf2-runtime2
watany-dev a4d220c
update integ
watany-dev d1d0236
Merge branch 'main' into cf2-runtime2
watany-dev c1ba48b
Merge branch 'main' into cf2-runtime2
watany-dev 77dc039
Merge branch 'aws:main' into cf2-runtime2
watany-dev 7d82d0e
enum to class
watany-dev 18b4cfe
fix lint
watany-dev 170ea4b
Apply suggestions from code review
kaizencc 96ba2d0
Merge branch 'main' into cf2-runtime2
watany-dev 1c35ae2
Merge branch 'main' into cf2-runtime2
watany-dev 50e9ca5
optional
watany-dev b0eebba
optional
watany-dev 87bc78e
Merge branch 'cf2-runtime2' of https://github.com/watany-dev/aws-cdk …
watany-dev 968fe51
default
watany-dev 4819dad
Merge branch 'main' into cf2-runtime2
watany-dev 783aed1
Merge branch 'main' into cf2-runtime2
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be better as an enum-like class, similar to how our other Rumtime types look.