Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(msk-alpha): cluster deployment fails in ap-southeast-1 #28112

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Nov 22, 2023

The reason is that the AwsCustomResource that this construct library uses calls describeCluster, which passes back all responses to CloudFormation, even if they are unused.

This PR restricts the return value to only the outputs that are actually read.

Fixes #28108


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 22, 2023 20:13
@github-actions github-actions bot added the p2 label Nov 22, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 22, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 and removed p2 labels Nov 22, 2023
@rix0rrr rix0rrr changed the title fix(msk-alpha): describeCluster output is too large fix(msk-alpha): cluster deployment fails in ap-southeast-1 Nov 23, 2023
@rix0rrr rix0rrr added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Nov 23, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 23, 2023 13:10

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 23, 2023
Copy link
Contributor

mergify bot commented Nov 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 27, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6b2585a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0ee4199 into main Nov 27, 2023
15 checks passed
@mergify mergify bot deleted the huijbers/too-large-msk branch November 27, 2023 14:59
Copy link
Contributor

mergify bot commented Nov 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-msk-alpha: msk cluster fails to deploy in ap-southeast-1 with Response object is too long error
3 participants