Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apigatewayv2): export newly graduated apigatewayv2 modules #28250

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

jgreenbow
Copy link
Contributor

The API Gateway V2 modules which were graduated to stable with 2.112.0 were not added to the main package exports. In particular:

  • aws-apigatewayv2-authorizers
  • aws-apigatewayv2-integrations

Closes #28239.

Now, I am not completely familiar with JSII and the CDK, so this may be only one part of the required solution to include these missing packages.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 labels Dec 4, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team December 4, 2023 21:27
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@jgreenbow jgreenbow changed the title Export newly graduated apigatewayv2 modules fix(apigatewayv2): export newly graduated apigatewayv2 modules Dec 4, 2023
sumupitchayan
sumupitchayan previously approved these changes Dec 4, 2023
@sumupitchayan sumupitchayan added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Dec 4, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 4, 2023 21:37

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@jgreenbow
Copy link
Contributor Author

Fixed the PR/commit message formatting, first time doing https://www.conventionalcommits.org/en/v1.0.0/

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 4, 2023
Copy link
Contributor

mergify bot commented Dec 4, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 4, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8504efa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c8627ce into aws:main Dec 4, 2023
12 checks passed
Copy link
Contributor

mergify bot commented Dec 4, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@jgreenbow jgreenbow deleted the patch-1 branch December 5, 2023 21:38
chenjane-dev pushed a commit to chenjane-dev/aws-cdk that referenced this pull request Dec 5, 2023
…8250)

The API Gateway V2 modules which were graduated to stable with [2.112.0](https://github.com/aws/aws-cdk/releases/tag/v2.112.0) were not added to the main package exports. In particular:

- aws-apigatewayv2-authorizers
- aws-apigatewayv2-integrations

Closes aws#28239.

Now, I am not completely familiar with JSII and the CDK, so this may be only one part of the required solution to include these missing packages. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-apigatewayv2: cannot find HttpLambdaIntegration switching from deprecated alpha package
3 participants