Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add author paulhcs to .mergify.yml and merit badger #28260

Merged

Conversation

paulhcsun
Copy link
Contributor

Adding new author to .mergify.yml and .github-merit-badger.yml as per contribution guidelines.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 5, 2023 18:16
@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Dec 5, 2023
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrap yourself into merit badger too! Check out mine: https://github.com/aws/aws-cdk/pull/26454/files

Also make sure to have your PR titles follow conventional commits! i.e. lowercasing.

@paulhcsun paulhcsun changed the title chore: Add author paulhcs to .mergify.yml chore: add author paulhcs to .mergify.yml Dec 5, 2023
@paulhcsun paulhcsun changed the title chore: add author paulhcs to .mergify.yml chore: add author paulhcs to .mergify.yml and merit badger Dec 5, 2023
@mergify mergify bot dismissed scanlonp’s stale review December 5, 2023 19:10

Pull request has been modified.

Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be your github username.

@mergify mergify bot dismissed scanlonp’s stale review December 5, 2023 19:19

Pull request has been modified.

Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7c9b08e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Dec 5, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@paulhcsun paulhcsun merged commit 89f9803 into aws:main Dec 5, 2023
12 checks passed
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 5, 2023
@paulhcsun paulhcsun deleted the add-paulhcs-to-mergify-core-permissions branch December 5, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants