Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cloud9-alpha): support image ids for Amazon Linux 2023 and Ubuntu 22.04 #28346

Merged
merged 3 commits into from
Dec 13, 2023
Merged

feat(cloud9-alpha): support image ids for Amazon Linux 2023 and Ubuntu 22.04 #28346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
399e40a
feat(cloud9-alpha): support image ids for Amazon Linux 2023 and Ubunt…
go-to-k Dec 13, 2023
025f74e
add a deprecated label
go-to-k Dec 13, 2023
58d6b69
Merge branch 'main' into feat/cloud9-new-image-id
mergify[bot] Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions packages/@aws-cdk/aws-cloud9-alpha/lib/environment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,19 @@ export enum ImageId {
*/
AMAZON_LINUX_2 = 'amazonlinux-2-x86_64',
/**
* Create using Ubunut 18.04
* Create using Amazon Linux 2023
*/
UBUNTU_18_04 = 'ubuntu-18.04-x86_64'
AMAZON_LINUX_2023 = 'amazonlinux-2023-x86_64',
/**
* Create using Ubuntu 18.04
*
* @deprecated Since Ubuntu 18.04 has ended standard support as of May 31, 2023, we recommend you choose Ubuntu 22.04.
*/
UBUNTU_18_04 = 'ubuntu-18.04-x86_64',
/**
* Create using Ubuntu 22.04
*/
UBUNTU_22_04 = 'ubuntu-22.04-x86_64',
}
/**
* Properties for Ec2Environment
Expand Down
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-cloud9-alpha/test/cloud9.environment.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,9 @@ test.each([

test.each([
[ImageId.AMAZON_LINUX_2, 'amazonlinux-2-x86_64'],
[ImageId.AMAZON_LINUX_2023, 'amazonlinux-2023-x86_64'],
[ImageId.UBUNTU_18_04, 'ubuntu-18.04-x86_64'],
[ImageId.UBUNTU_22_04, 'ubuntu-22.04-x86_64'],
])('has image ID property (%s)', (imageId, expected) => {
new cloud9.Ec2Environment(stack, 'C9Env', {
vpc,
Expand Down