-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): messages from annotations.ts
can show up as [object Object]
#28414
Conversation
annotations.ts
can show up as [object Object]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
annotations.ts
can show up as [object Object]
annotations.ts
can show up as [object Object]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lmammino
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
CDK Version: 2.115.0 (build 58027ee)
Os: macOS 14.2 (BuildVersion: 23C64)
I have observed the following warning showing up in my console today when running
cdk
:I was able to track down where this message was generated and apply a patch to see the error in a more descriptive format.
For the records the error in my case was:
The fix proposed here makes sure that if
I am not sure this is the best way to fix this issue. The signature of the
addMessage
seems to expect astring
for themessage
value, so maybe the error needs to be corrected downstream where theaddMessage
call is made (which judging from the stack trace seems to come fromaws-cdk-lib/aws-lambda/lib/function-base.js
).Thoughts?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license