Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make the service-spec update more user friendly #28441

Merged

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Dec 20, 2023

The current wording made it hard for beginners to understand what the PRs actually do.
This should improve discoverability of L1 changes.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 20, 2023 17:42
@github-actions github-actions bot added the p2 label Dec 20, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 20, 2023
Co-authored-by: Glib Shpychka <23005347+gshpychka@users.noreply.github.com>
@mrgrain mrgrain added pr/do-not-merge This PR should not be merged at this time. and removed pr/do-not-merge This PR should not be merged at this time. labels Dec 20, 2023
@mrgrain
Copy link
Contributor Author

mrgrain commented Dec 20, 2023

Tested here: #28442

@kaizencc this can be reviewed now

Copy link
Contributor

mergify bot commented Dec 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2c3d5f9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6950d86 into main Dec 20, 2023
12 checks passed
@mergify mergify bot deleted the mrgrain/chore/make-service-spec-updates-more-user-friendly branch December 20, 2023 19:37
Copy link
Contributor

mergify bot commented Dec 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this pull request Jan 5, 2024
The current wording made it hard for beginners to understand what the PRs actually do.
This should improve discoverability of L1 changes.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants