fix(custom-resources): custom resource response may silently get dropped #28826
Conversation
It looks like in our custom resource response senders, we are not checking the HTTP result code of making the `PUT` request to the presigned URL. This allows for the possibility that we don't detect that we got a 500, exit successfully, and drop the response on the floor. Also log the URL we're writing to so that it becomes easier to debug missing object PUTs. Yes, I am aware that there is awkward duplication going on here. I'm optimizing for quick delivery here.
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
It looks like in our custom resource response senders, we are not checking the HTTP result code of making the
PUTrequest to the presigned URL.This allows for the possibility that we don't detect that we got a 500, exit successfully, and drop the response on the floor.
Also log the URL we're writing to so that it becomes easier to debug missing object PUTs.
(Yes, I am aware that there is awkward duplication going on here. I'm trying to get this out quickly, and doing a full refactor will take me time that I don't have to spend on this)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license