Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(assertions): add stack tagging assertions #29247

Merged
merged 14 commits into from
Apr 10, 2024
Merged

feat(assertions): add stack tagging assertions #29247

merged 14 commits into from
Apr 10, 2024

Commits on Mar 8, 2024

  1. feat(assertions): add stack tagging assertions 

    Adds a Tag class to the assertions library that permits assertions
against tags on synthesized CDK stacks.
    @jamestelfer
    jamestelfer committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    b8a61a0 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Merge branch 'main' into assertions/add-stack-tag-checks

    @scanlonp
    scanlonp authored Mar 21, 2024
    Configuration menu
    Copy the full SHA
    0da20d1 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. fix: update formatting of import 

    Review feedback

Co-authored-by: Parker Scanlon <69879391+scanlonp@users.noreply.github.com>
    @jamestelfer @scanlonp
    jamestelfer and scanlonp authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    b9ed0dc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into assertions/add-stack-tag-checks

    @jamestelfer
    jamestelfer authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    2d1e677 View commit details
    Browse the repository at this point in the history

  3. fix(assertions): remove unused imports

    @jamestelfer
    jamestelfer committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    24d0222 View commit details
    Browse the repository at this point in the history

  4. feat(assertions): add hasNone() to Tags API 

    Convenience method over `hasValues(Match.exact({}))`. Required as `Match.absent()` (the natural choice) will not act as the user expects.
    @jamestelfer
    jamestelfer committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    2d37f1f View commit details
    Browse the repository at this point in the history

  5. fix(assertions): throw useful error when Tags.hasValues() is called… 

    … with the `absent` matcher

Since the value is defaulted to `{}`, the absent matcher will not work as expected.

We throw an error here instead of changing the Matcher under the covers. This ensures the API is transparent about the limitation, rather than covering it up.
    @jamestelfer
    jamestelfer committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    458bc75 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. tests(assertions): add more complex matcher tests

    @jamestelfer
    jamestelfer committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    ae015e9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into assertions/add-stack-tag-checks

    @jamestelfer
    jamestelfer authored Mar 28, 2024
    Configuration menu
    Copy the full SHA
    c4a1081 View commit details
    Browse the repository at this point in the history

  3. docs(annotations): add more scenarios to Tags documentation

    @jamestelfer
    jamestelfer committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    8d6044e View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2024

  1. docs(assertions): fix Tags usage examples 

    Improvements to allow Rosetta to test the documentation.
    @jamestelfer
    jamestelfer committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    d71091d View commit details
    Browse the repository at this point in the history

  2. fix(assertions): revise doc for hasNone() 

    Bring doc up to scratch, removing copy-pasta and properly explaining usage intent.
    @jamestelfer
    jamestelfer committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    9ad981b View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into assertions/add-stac… 

    …k-tag-checks
    @jamestelfer
    jamestelfer committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    22a2ef9 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Merge branch 'main' into assertions/add-stack-tag-checks

    @mergify
    mergify[bot] authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    4dcbf74 View commit details
    Browse the repository at this point in the history