Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CLI): change-set diff not required for new stack diffs #29268

Closed
wants to merge 14 commits into from
Closed

fix(CLI): change-set diff not required for new stack diffs #29268

wants to merge 14 commits into from

Commits on Feb 26, 2024

  1. add check for new stak in fullDiff function 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    bf7c7bb View commit details
    Browse the repository at this point in the history

  2. add unit test 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    ec2fe4e View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. fix diff test expect 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    f578824 View commit details
    Browse the repository at this point in the history

  2. expect NewResource change impact to be WILL_CREATE in test 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    f793b87 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into sumughan/fix-changeset-delete-stack

    @sumupitchayan
    sumupitchayan authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    cedf900 View commit details
    Browse the repository at this point in the history

  4. fix diff test string problems in test expect 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    400147e View commit details
    Browse the repository at this point in the history

  5. Merge main 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    4df1cf0 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into sumughan/fix-changeset-delete-stack

    @sumupitchayan
    sumupitchayan authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    0d2fc04 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. try fixing migrate import diff in cdktoolkit 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    bcb544c View commit details
    Browse the repository at this point in the history

  2. Revert changes to import test expect 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    01071bd View commit details
    Browse the repository at this point in the history

  3. Merge branch 'sumughan/fix-changeset-delete-stack' of https://github.… 

    …com/aws/aws-cdk into sumughan/fix-changeset-delete-stack
    @sumupitchayan
    sumupitchayan committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    d4cb526 View commit details
    Browse the repository at this point in the history

  4. add important info for all changeSets, just don't do filterFalsePosit… 

    …ives for migrate

Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    7b678ca View commit details
    Browse the repository at this point in the history

  5. Revert "try fixing migrate import diff in cdktoolkit" 

    This reverts commit bcb544c.
    @sumupitchayan
    sumupitchayan committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    bb73010 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into sumughan/fix-changeset-delete-stack

    @sumupitchayan
    sumupitchayan authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c94c8ae View commit details
    Browse the repository at this point in the history