Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(integ-test-alpha): add log group retention days to integ test stack #29277

Merged
merged 7 commits into from
Mar 15, 2024

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Feb 27, 2024

Issue # (if applicable)

Closes #29260

Reason for this change

CloudWatch log groups created by the integ tests are set to never expire, so end up cluttering up your aws account and need manual cleanup.

Description of changes

Added custom log group with log group retention

Description of how you validated changes

All existing tests and new tests pass.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team February 27, 2024 10:44
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 labels Feb 27, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 27, 2024
@GavinZZ GavinZZ marked this pull request as ready for review February 27, 2024 13:00
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer that we make this a configurable field rather than just assigning an arbitrary time period.

@paulhcsun
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Mar 14, 2024

update

✅ Branch has been successfully updated

@GavinZZ GavinZZ dismissed TheRealAmazonKendra’s stale review March 14, 2024 22:18

Dismissing as the feedback is addressed

Copy link
Contributor

mergify bot commented Mar 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f596764
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9ec41ad into main Mar 15, 2024
12 checks passed
@mergify mergify bot deleted the yuanhaoz/update_log_group branch March 15, 2024 00:09
Copy link
Contributor

mergify bot commented Mar 15, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mokele
Copy link

mokele commented Sep 12, 2024

This PR has a bug that if you use this feature then you cannot have more than 1 long running assertion stack co-exist in the same aws account.

It's common to have shared aws accounts, and this feature uses the hardcoded singleton uuid value with id then used for the log group /aws/logs/{id}, making it the same across the whole account not just the current stack, making it not possible to have multiple longer running assertion stacks (with --no-clean).

I'm not sure yet if there is a way to circumvent this and get to override the uuid that is baked in here that results in part of the singleton functions's id 😢

I'll work on writing up a proper bug issue when I have a moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
6 participants