-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rds): eliminating the need for explicit secret.grantRead()
invokes when using DataAPI with Aurora cluster
#29399
feat(rds): eliminating the need for explicit secret.grantRead()
invokes when using DataAPI with Aurora cluster
#29399
Conversation
secret.grantRead()
invokes when using DataAPIsecret.grantRead()
invokes when using DataAPI with Aurora cluster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Issue # (if applicable)
Closes #29362.
Reason for this change
As discussed there, we should invoke
secret.grantRead()
explicitly when using DataAPI with Aurora cluster.Because it's inconvenient for users, I made
secret.grantRead()
be invoked withincluster.grantDataApiAccess()
.Description of changes
cluster.secret
fromDatabaseClusterNew
toDatabaseClusterBase
to use it withinDatabaseClusterBase.grantDataApiAccess()
secret.grantRead()
incluster.grantDataApiAccess()
secret
property toDatabaseClusterAttributes
Points of concern
DatabaseClusterBase
class is extended byImportedDatabaseCluster
class. Therefore, it is necessary to defineImportedDatabaseCluster.secret
.I simply added
secret
props toDatabaseClusterAttributes
but I cannot believe this is the best way.Other ways are..
secretArn
toDatabaseClusterAttributes
ImportedDatabaseCluster.secret
becomes always undefinedDescription of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license