chore(ec2): update WindowsVersions enum

[nmussy]

Issue # (if applicable)

Could not find any in the backlog

Reason for this change

Update the CDK EC2 listed Windows versions to match the current availability

Description of changes

• Added new Windows images
• Marked as deprecated old Windows images

Description of how you validated changes

Once again, I'm comparing the CDK enumeration to live SDK data, this time using the ec2:DescribeImages API command, with the following parameters:

{
	Owners: ["amazon"],
	Filters: [{ Name: "name", Values: ["Windows_Server*"] }],
}

Images that are no longer listed by this command are marked as @deprecated, and new images are added to the enum

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[nmussy]

I'd accidentally removed some of the previous enum values, I restored them and made sure I didn't miss any:

$ git checkout chore-ec2-windows-versions
$ grep -i '^  WINDOWS' lib/windows-versions.ts | sort > new_versions
$ git checkout main
$ grep -i '^  WINDOWS' lib/windows-versions.ts | sort > old_versions
$ diff old_versions new_versions | grep -i '^<'

[nmussy]

Not sure why or when Windows_Server-2019-English-Core-ContainersLatest and Windows_Server-2019-English-Full-ContainersLatest were removed, see Windows AMI version history, but they are unavaialble:

$ aws ec2 describe-images --owners amazon --filters 'Name=name,Values=Windows_Server-2019-English-Core-ContainersLatest'
{
    "Images": []
}
$ aws ec2 describe-images --owners amazon --filters 'Name=name,Values=Windows_Server-2019-English-Full-ContainersLatest'
{
    "Images": []
}

[nmussy]

See f3092e6 (#29435)

[msambol]

What Region did you use? us-east-1? Could there be any differences by Region?

[nmussy]

@msambol Yes, I'm using us-east-1, and I'm not seeing any differences between regions. I assume the AWS Windows images are deployed globally

[TheRealAmazonKendra]

That is... so many. Thanks for taking the time to get these added!

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 9a4dac6
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[scanlonp]

Hey @nmussy, we got this issue reported #29737. It looks like the new enum versions do not play well with certain ways to define the Windows image. Going to revert this for now.