Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(synthetics): update runtimes #29446

Merged
merged 5 commits into from
Mar 15, 2024
Merged

chore(synthetics): update runtimes #29446

merged 5 commits into from
Mar 15, 2024

Conversation

nmussy
Copy link
Contributor

@nmussy nmussy commented Mar 11, 2024

Issue # (if applicable)

Could not find any in the backlog

Reason for this change

Update the CDK listed Synthetics runtimes to match the current availability, as well as add missing deprecated versions

Description of changes

  • Added new runtimes
  • Marked existing runtimes as deprecated
  • Add previously deprecated runtimes
    • For the sake of consistency and readability, the static fields for syn-1.0 and syn-nodejs-2.* were still named SYNTHETICS_NODEJS_PUPPETEER_*
  • Fix documented versions for existing runtimes
  • Added {@link} tags to match the web documentation

Description of how you validated changes

I compared the current CDK versions to live SDK data, using the synthetics:DescribeRuntimeVersions API results. Deprecated versions were established using the DeprecationDate field

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Mar 11, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 11, 2024 19:37
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Mar 11, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 11, 2024
jfuss
jfuss previously requested changes Mar 14, 2024
View reviewed changes
packages/aws-cdk-lib/aws-synthetics/lib/runtime.ts Outdated
Comment on lines 33 to 35
* @deprecated Legacy runtime no longer supported by AWS Lambda. Migrate to the latest NodeJS Puppeteer runtime.
*/
public static readonly SYNTHETICS_NODEJS_PUPPETEER_1_0 = new Runtime('syn-1.0', RuntimeFamily.NODEJS);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should add ones that are already deprecated. Can we remove these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My original thought for all these PRs was to have parity between the SDK and the CDK, as a starting off point for continuous, automatic checks. I can always ignore SDK versions/engines/runtimes etc. that are deprecated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

@jfuss jfuss self-assigned this Mar 14, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 14, 2024
@mergify mergify bot dismissed jfuss’s stale review March 15, 2024 07:17

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 15, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 15, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 15, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ebf4b1c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 87139ab into aws:main Mar 15, 2024
12 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 15, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot mentioned this pull request Mar 18, 2024
Closed
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
@msambol msambol mentioned this pull request Apr 4, 2024
Closed
2 tasks
@jwilson-anonyome jwilson-anonyome mentioned this pull request Jul 14, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfuss jfuss jfuss approved these changes

Assignees

@jfuss jfuss

Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmussy @aws-cdk-automation @jfuss