feat(stepfunctions-tasks): create scheduler #29458

badmintoncryer · 2024-03-12T06:06:03Z

Issue # (if applicable)

Reason for this change

Although the creation of schedule task is supported, the AWS CDK currently lacks the capability to create these without a custom task definition.

Description of changes

I've introduced the EventBridgeSchedulerCreateScheduleTask class to address this gap.

The original issue discussed the need for both creating and updating schedules. However, to maintain focus and simplicity, this PR will only cover the creation aspect. A subsequent PR will be dedicated to schedule updates.

Description of how you validated changes

I have added both integ and unit tests.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

badmintoncryer · 2024-03-12T06:07:31Z

@cshields236 Please wait for a while.

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

lpizzinidev

Thanks 👍 Left comments for adjustments

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/eventbridge-scheduler/create-schedule.ts

lpizzinidev · 2024-06-12T16:56:44Z

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/eventbridge-scheduler/create-schedule.ts

+   *
+   * @see https://docs.aws.amazon.com/scheduler/latest/UserGuide/schedule-types.html
+   */
+  readonly scheduleExpression: string;


What about using a Schedule class similar to this?

It's a really nice suggestion. Do you mean implementing the Schedule class in create-schedule.ts? Or importing this class directly?

I see that the class is declared in multiple packages already.
I think you can create it inside the aws-stepfunctions-tasks/lib package.

I defined Schedule class in create-schedule.ts.

I also referred to this class, particularly the rate() method.
https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-events/lib/schedule.ts#L11

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/eventbridge-scheduler/create-schedule.ts

packages/aws-cdk-lib/aws-stepfunctions-tasks/README.md

badmintoncryer

Thank you for your review!! I've addressed your comments.
I have one question about implementation of Schedule class.

badmintoncryer · 2024-03-14T13:52:08Z

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/eventbridge-scheduler/create-schedule.ts

+   *
+   * @see https://docs.aws.amazon.com/scheduler/latest/UserGuide/managing-targets.html
+   */
+  readonly target: string;


I want to name this parameter as targetArn but it causes linter failure.

error: [awslint:props-no-arn-refs:aws-cdk-lib.aws_stepfunctions_tasks.EventBridgeSchedulerCreateScheduleTaskProps.targetArn] props must use strong types instead of attributes. props should not have "arn" suffix

badmintoncryer · 2024-06-22T06:15:41Z

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/eventbridge-scheduler/create-schedule.ts

+   *
+   * @see https://docs.aws.amazon.com/scheduler/latest/UserGuide/schedule-types.html
+   */
+  readonly scheduleExpression: string;


It's a really nice suggestion. Do you mean implementing the Schedule class in create-schedule.ts? Or importing this class directly?

packages/aws-cdk-lib/aws-stepfunctions-tasks/README.md

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/eventbridge-scheduler/create-schedule.ts

lpizzinidev

Thanks 👍 Left some comments for adjustments.
Sorry for the late review, I've been a bit busy recently.

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/eventbridge-scheduler/create-schedule.ts

…cheduler/create-schedule.ts Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

…ation

badmintoncryer · 2024-07-20T04:55:55Z

@lpizzinidev Thanks always!! I've addressed your comments. There is no rush, so please feel free to review it whenever you have time.

lpizzinidev

Thanks 👍 Left suggestions for some final adjustments.

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/eventbridge-scheduler/create-schedule.ts

…cheduler/create-schedule.ts Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

badmintoncryer · 2024-07-22T12:43:49Z

@lpizzinidev Thanks a lot!! I've updated my PR according to your suggestion😁

aws-cdk-automation · 2024-08-23T14:04:16Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 1de32c7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Mar 12, 2024

aws-cdk-automation requested a review from a team March 12, 2024 06:06

github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label Mar 12, 2024

aws-cdk-automation previously requested changes Mar 12, 2024

View reviewed changes

badmintoncryer had a problem deploying to test-pipeline March 13, 2024 14:46 — with GitHub Actions Failure

badmintoncryer had a problem deploying to test-pipeline March 14, 2024 00:25 — with GitHub Actions Failure

badmintoncryer had a problem deploying to test-pipeline March 14, 2024 01:27 — with GitHub Actions Failure

badmintoncryer had a problem deploying to test-pipeline March 14, 2024 01:43 — with GitHub Actions Failure

badmintoncryer marked this pull request as ready for review March 14, 2024 01:43

badmintoncryer force-pushed the 29351-schedulerIntegration branch 2 times, most recently from 562fae8 to 6a21c6d Compare March 15, 2024 04:36

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 15, 2024

github-actions bot mentioned this pull request Mar 18, 2024

Weekly PR metrics report #29527

Closed

github-actions bot mentioned this pull request Apr 1, 2024

Monthly PR metrics report #29668

Closed

lpizzinidev suggested changes Jun 12, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 12, 2024

badmintoncryer force-pushed the 29351-schedulerIntegration branch from 21bf7d1 to 1c9a271 Compare June 17, 2024 13:47

badmintoncryer commented Jun 22, 2024

View reviewed changes

badmintoncryer added 8 commits June 22, 2024 16:59

feat: add create-schedule.ts

353c51f

feat: updte create-schedule.ts

1451fc7

feat: add validation

d6ba324

feat: export

fcce464

test: integ test

7681b18

test: update integ test

728ed56

test: add unit test

5016085

test: add unit test

d2940e8

badmintoncryer added 4 commits July 5, 2024 12:13

refactor integ

480a5d3

fix readme

e5032bd

Merge branch 'main' into 29351-schedulerIntegration

1206ee2

update unit test

b8cc4f8

lpizzinidev suggested changes Jul 17, 2024

View reviewed changes

badmintoncryer and others added 7 commits July 20, 2024 09:37

Update packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/eventbridge-s…

e8e707b

…cheduler/create-schedule.ts Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

Update packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/eventbridge-s…

366e355

…cheduler/create-schedule.ts Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

Update packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/eventbridge-s…

61aef85

…cheduler/create-schedule.ts Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

Update packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/eventbridge-s…

78d0003

…cheduler/create-schedule.ts Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

fix

f96e7ea

decrypt only

a2f4fa0

Merge remote-tracking branch 'origin/main' into 29351-schedulerIntegr…

56e6cf8

…ation

lpizzinidev approved these changes Jul 21, 2024

View reviewed changes

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 21, 2024

badmintoncryer and others added 4 commits July 22, 2024 09:21

Update packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/eventbridge-s…

fa444e0

…cheduler/create-schedule.ts Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

Update packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/eventbridge-s…

23370bd

…cheduler/create-schedule.ts Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

Update packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/eventbridge-s…

5321a25

…cheduler/create-schedule.ts Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

update comments

a14f0f7

badmintoncryer added 4 commits July 22, 2024 21:43

Merge branch 'main' into 29351-schedulerIntegration

2c936db

Merge branch 'main' into 29351-schedulerIntegration

108c7b4

Merge branch 'main' into 29351-schedulerIntegration

86bfd6b

Merge branch 'main' into 29351-schedulerIntegration

0bd4923

paulhcsun self-assigned this Jul 29, 2024

badmintoncryer added 4 commits August 7, 2024 21:15

Merge branch 'main' into 29351-schedulerIntegration

5f1f2c4

Merge branch 'main' into 29351-schedulerIntegration

9123bb0

Merge branch 'main' into 29351-schedulerIntegration

e272803

Merge branch 'main' into 29351-schedulerIntegration

1de32c7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(stepfunctions-tasks): create scheduler #29458

feat(stepfunctions-tasks): create scheduler #29458

badmintoncryer commented Mar 12, 2024 •

edited

Loading

badmintoncryer commented Mar 12, 2024

aws-cdk-automation left a comment

lpizzinidev left a comment

lpizzinidev Jun 12, 2024

badmintoncryer Jun 22, 2024

lpizzinidev Jun 26, 2024

badmintoncryer Jul 4, 2024 •

edited

Loading

badmintoncryer left a comment •

edited

Loading

badmintoncryer Mar 14, 2024

badmintoncryer Jun 22, 2024

lpizzinidev left a comment

badmintoncryer commented Jul 20, 2024

lpizzinidev left a comment

badmintoncryer commented Jul 22, 2024

aws-cdk-automation commented Aug 23, 2024

feat(stepfunctions-tasks): create scheduler #29458

Are you sure you want to change the base?

feat(stepfunctions-tasks): create scheduler #29458

Conversation

badmintoncryer commented Mar 12, 2024 • edited Loading

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

badmintoncryer commented Mar 12, 2024

aws-cdk-automation left a comment

Choose a reason for hiding this comment

lpizzinidev left a comment

Choose a reason for hiding this comment

lpizzinidev Jun 12, 2024

Choose a reason for hiding this comment

badmintoncryer Jun 22, 2024

Choose a reason for hiding this comment

lpizzinidev Jun 26, 2024

Choose a reason for hiding this comment

badmintoncryer Jul 4, 2024 • edited Loading

Choose a reason for hiding this comment

badmintoncryer left a comment • edited Loading

Choose a reason for hiding this comment

badmintoncryer Mar 14, 2024

Choose a reason for hiding this comment

badmintoncryer Jun 22, 2024

Choose a reason for hiding this comment

lpizzinidev left a comment

Choose a reason for hiding this comment

badmintoncryer commented Jul 20, 2024

lpizzinidev left a comment

Choose a reason for hiding this comment

badmintoncryer commented Jul 22, 2024

aws-cdk-automation commented Aug 23, 2024

AWS CodeBuild CI Report

badmintoncryer commented Mar 12, 2024 •

edited

Loading

badmintoncryer Jul 4, 2024 •

edited

Loading

badmintoncryer left a comment •

edited

Loading