-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(triggers): store provider as class property #29669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Clarification Request Also does this need an integration test beyond the tests I already added? If so where would it go/what would it do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I have just one comment inline but I think we also need to see an integ test added for this to show that it works for your intended use case.
* Singleton Trigger provider | ||
* @type {CustomResourceProvider} | ||
*/ | ||
crProvider: CustomResourceProvider; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we either call this provider
or use the whole customResourceProvider
?
Also, please note that the title of a fix should describe the bug, not the solution. Could you please adjust that? |
@Mergifyio update |
✅ Branch has been successfully updated |
Also, I hadn't noticed that your build failed and that you asked a question about it. The failure lines here are pretty hard to find but they're:
The docstring on line 116 of |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Issue # (if applicable)
Closes #29657
Reason for this change
Unable to modify Triggers provider using conventional escape hatches
Description of changes
Stored Trigger provider as class property to be user-accessible
Description of how you validated changes
Was unable to test changes due to issues getting project installed locally
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license