-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ec2): support for g6 and gr6 instance types in aws-ec2 #29735
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request: This PR is similar to #27823, which didn't need changes to the README and tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update this method with the newly added instance types?
@lpizzinidev Thank you for your review!
I added new instance types in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
InstanceClass.G6, InstanceClass.GR6, | ||
InstanceClass.INF1, InstanceClass.INF2]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
InstanceClass.G6, InstanceClass.GR6, | |
InstanceClass.INF1, InstanceClass.INF2]; | |
InstanceClass.G6, InstanceClass.GR6, InstanceClass.INF1, InstanceClass.INF2]; |
It should fit in one line.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably seems like overkill but we've had some recent regressions because of similar new versions added I'd like to see these values used in an integ test. Could you please add that? You're welcome to add these instance types to an existing test instead of creating an entirely new test.
There are some limitation on these new instance types. We cannot merge this at this time. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
Do these limitations still exist? Do you have any insight on what these limitations are? |
Reason for this change
The G6 instance types were introduced in April 2024. The instance types are already supported in CloudFormation.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license