feat(elasticloadbalancingv2): add removeSuffix param for ExternalApplicationListener.addAction()

[ahammond]

Issue # (if applicable)

Closes #29496

Reason for this change

See #29513 (props based solution instead of feature-flag)

Description of changes

Adds a removeSuffix property to addAction method to address problems due to logicalId inconsistency.

Description of how you validated changes

UTs. Per IT document, integration tests are not necessary.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[ahammond]

Exemption Request: this change doesn't touch any of the aspects which would require IT.

[vinayak-kukreja]

I have a general question and please let me know if I am missing historical context here :)

• Is addAction covering all that is done by addTargetGroups and adds more to it? If yes, do we want two functions doing somewhat similar things to exist? I believe it adds more confusion
• If prior scenario is true, where addAction just supercedes addTargetGroups, then why can we just not deprecate addTargetGroups and remove Rule suffix from addAction and add all of this behind a feature flag?

[vinayak-kukreja]

I have a general question and please let me know if I am missing historical context here :)

* Is `addAction` covering all that is done by `addTargetGroups` and adds more to it? If yes, do we want two functions doing somewhat similar things to exist? I believe it adds more confusion

* If prior scenario is true, where `addAction` just supercedes `addTargetGroups`, then why can we just not deprecate `addTargetGroups` and remove `Rule` suffix from `addAction` and add all of this behind a feature flag?

Ok, so I see addAction provides more control but addTargetGroups provides an abstracted version of it's functionality with some defaults.
In that case, IMO this configuration via props is becoming a bit confusing. I understand that we are trying to minimize using feature flags but adding it here probably will make a cleaner contract for the user. Thoughts?

[ahammond]

I removed addTargetGroup() related changes from this PR. I really need the addAction() stuff resolved so we can move forward.

[ahammond]

Ok, so I see addAction provides more control but addTargetGroups provides an abstracted version of it's functionality with some defaults. In that case, IMO this configuration via props is becoming a bit confusing. I understand that we are trying to minimize using feature flags but adding it here probably will make a cleaner contract for the user. Thoughts?

I've pulled out the stuff addressing the addTargetGroups from this PR to only address the problem which is blocking us. I think that the Right Way to address this going forward for the addTargetGroups() is a feature flag along the lines of what I wrote with #29513

But let's go one step at a time.

[TheRealAmazonKendra]

@Mergifyio update

[mergify]

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

[TheRealAmazonKendra]

Oh mergify...

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 573af28
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.