Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update name of sdk-v2-to-v3-adapter and improve documentation #29847

Merged
merged 10 commits into from
Apr 17, 2024

Conversation

colifran
Copy link
Contributor

@colifran colifran commented Apr 15, 2024

Issue # (if applicable)

Closes #29843

Reason for this change

The AWS SDK V2 is being deprecated. The sdk-v2-to-v3-adapter was created as a way to migrate AwsCustomResource to use AWS SDK V3 without introducing breaking changes. The documentation for the adapter does not provide enough detail about what it is used for and what functionality it provides. Additionally, the naming of the adapter should convey that it is used to provide an abstraction over all SDK versions, not just SDK V2 to SDK V3.

Description of changes

The sdk-v2-to-v3-adapter was changed to aws-custom-resource-sdk-adapter. Any usage of sdk-v2-to-v3-adapter was updated to now use aws-custom-resource-sdk-adapter. The README for aws-custom-resource-sdk-adapter was improved to provide an overview of the tooling that exists as part of the adapter.

Description of how you validated changes

No new unit tests or integ tests were needed as part of this PR. The current build is succeeding which means that the naming update has not introduced a breaking change.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Signed-off-by: Francis <colifran@amazon.com>
@github-actions github-actions bot added the p2 label Apr 15, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team April 15, 2024 22:55
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 15, 2024
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
@colifran colifran marked this pull request as ready for review April 16, 2024 22:25
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 16, 2024
Copy link
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀 ! Left 1 minor comment, but nothing blocking

"name": "@aws-cdk/sdk-v2-to-v3-adapter",
"description": "Adapter to convert AWS SDK v2 to AWS CDK v3 calls",
"name": "@aws-cdk/aws-custom-resource-sdk-adapter",
"description": "Adapter to convert AWS SDK v2 to AWS CDK v3 calls for AwsCustomResource",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we update this description to no longer refer to this as converting v2 to v3 calls, but maybe something like Adapter to convert AWS CDK to AWS SDK compatible calls (or something more generic)?

Copy link
Contributor

mergify bot commented Apr 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 17, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b1b4b9f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 39755fd into main Apr 17, 2024
16 checks passed
@mergify mergify bot deleted the colifran/update-sdk-v2-to-v3-adapter branch April 17, 2024 12:06
Copy link
Contributor

mergify bot commented Apr 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDKv3-09: Update naming and documentation for @aws-cdk/sdk-v2-to-v3-adapter
3 participants