Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add assertions to integ tests using AwsCustomResource #29929

Merged
merged 12 commits into from
Apr 23, 2024

Conversation

colifran
Copy link
Contributor

@colifran colifran commented Apr 23, 2024

Closes #29937

Reason for this change

Adding assertions for AwsCustomResource will improve our test coverage.

Description of changes

Added assertions for AwsCustomResource to integ tests that were impacted by this PR.

Description of how you validated changes

Assertions were validated by running the integ tests and verifying that it succeeded.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
@aws-cdk-automation aws-cdk-automation requested a review from a team April 23, 2024 02:27
@github-actions github-actions bot added the p2 label Apr 23, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 23, 2024
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
@colifran colifran changed the title chore: add assertiones to integ tests using AwsCustomResource chore: add assertions to integ tests using AwsCustomResource Apr 23, 2024
colifran and others added 4 commits April 23, 2024 11:28
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 51da0af
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Lgtm!

Copy link
Contributor

mergify bot commented Apr 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@colifran colifran marked this pull request as ready for review April 23, 2024 20:57
@mergify mergify bot merged commit 1bdd3fa into main Apr 23, 2024
22 checks passed
@mergify mergify bot deleted the colifran/aws-cr-assertions branch April 23, 2024 20:58
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertions for AwsCustomResource integ tests (1/2)
3 participants