-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ebs): set default volumeType to gp3(under feature flag) #29934
Merged
mergify
merged 15 commits into
aws:main
from
pahud:pahud/ec-change-default-volume-29931
Apr 30, 2024
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a9c1cd0
default to gp3
pahud e38f8af
update doc string
pahud 3f97d31
minor
pahud 4a25b5d
update test
pahud 76492b8
update the md
pahud ae488ea
update md
pahud c94465f
revert
pahud c7cf0d1
revert
pahud 0b70f7d
rev
pahud 54afe0d
rev
pahud aa40ff7
update README
pahud 73bb0b0
Merge branch 'main' into pahud/ec-change-default-volume-29931
pahud a9d5019
Merge branch 'main' into pahud/ec-change-default-volume-29931
mergify[bot] efa1559
Merge branch 'main' into pahud/ec-change-default-volume-29931
GavinZZ 2082d37
Merge branch 'main' into pahud/ec-change-default-volume-29931
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to have something like
"@aws-cdk/aws-ec2:ebsDefaultVolume": "gp3"
? The current setup makes future changes in the default volume type a little more awkward, we'll have to have multipleaws-cdk/aws-ec2:ebsDefaultXXXVolume
flags, make sure there are no conflicts, etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's say if we introduce
"@aws-cdk/aws-ec2:ebsDefaultVolume": "gp3"
in this PR and after a while AWS announcesgp4
as a new default and we modify this feature flag to"@aws-cdk/aws-ec2:ebsDefaultVolume": "gp4"
, this would cause breaking changes for those opting ingp3
and we still need a check to see if they have explicitly enable this flag asgp3
. I am not sure if that would be easier to maintain. Another consideration is conventionally our feature flags are boolean except for target partitions and we generally don't update value of existing feature flags. Will check this with the maintainers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't we only change the recommended value to
gp4
? Users that opted in togp3
would be in the same situation as those who enabledebsDefaultGp3Volume
if we introduceebsDefaultGp4Volume
. Arguably even worse off, since they would both need to disableebsDefaultGp3Volume
and enableebsDefaultGp4Volume
, vs just updatingebsDefaultVolume
togp4
.I'm leaving it up to you guys, I might not be seeing the whole picture, just throwing it out there 👍