Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appsync): add Enhanced Monitoring #29940

Closed

Conversation

piotrmoszkowicz
Copy link
Contributor

Issue

Closes #29933.

Reason for this change

AppSync team lately added feature to allow for more granular metrics for AppSync. It was incorporated to the AWS CloudFormation, but not yet to the AWS CDK.

Description of changes

I've added ENUMs for new values. Added everything connected with Enhanced Monitoring on Data Sources, Resolver & GraphQL API level. Also added paragraph into the documentation describing the feature.

Description of how you validated changes

Added unit tests for Data Sources, Resolver & GraphQL API. All passes.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Apr 23, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team April 23, 2024 21:56
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Apr 23, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@piotrmoszkowicz piotrmoszkowicz changed the title feat(aws-appsync): Add Enhanced Monitoring feat(appsync): Add Enhanced Monitoring Apr 23, 2024
@piotrmoszkowicz piotrmoszkowicz changed the title feat(appsync): Add Enhanced Monitoring feat(appsync): add Enhanced Monitoring Apr 23, 2024
@piotrmoszkowicz
Copy link
Contributor Author

piotrmoszkowicz commented Apr 23, 2024

Exemption Request

I don't think it is worth adding integration test for this one - it just adds missing property to L2 construct.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 46556cd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label May 23, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-appsync): Add Enhanced Metrics configuration to CDK
2 participants