chore: add assertions to integ tests using AwsCustomResource
#29950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colifran
reviewed
Apr 24, 2024
...mework-integ/test/custom-resources/test/aws-custom-resource/integ.aws-custom-resource-vpc.ts
Outdated
Show resolved
Hide resolved
colifran
reviewed
Apr 24, 2024
...@aws-cdk-testing/framework-integ/test/aws-synthetics/test/integ.canary-auto-delete-lambda.ts
Outdated
Show resolved
Hide resolved
colifran
reviewed
Apr 24, 2024
...ork-integ/test/custom-resources/test/aws-custom-resource/integ.aws-custom-resource-athena.ts
Outdated
Show resolved
Hide resolved
colifran
reviewed
Apr 24, 2024
...ork-integ/test/custom-resources/test/aws-custom-resource/integ.aws-custom-resource-athena.ts
Outdated
Show resolved
Hide resolved
colifran
reviewed
Apr 24, 2024
...ork-integ/test/custom-resources/test/aws-custom-resource/integ.aws-custom-resource-athena.ts
Show resolved
Hide resolved
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
colifran
reviewed
Apr 24, 2024
| testCases: [stack], | ||
| diffAssets: true, | ||
| }); | ||
|
|
||
| app.synth(); | ||
| // Assertion to check if TestWG workgroup is present in the list of workgroups | ||
| integTest.assertions.awsApiCall('Athena', 'listWorkGroups') |
colifran
reviewed
Apr 25, 2024
...@aws-cdk-testing/framework-integ/test/aws-synthetics/test/integ.canary-auto-delete-lambda.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
colifran
reviewed
Apr 25, 2024
|
|
||
| new integ.IntegTest(app, 'AwsCustomResourceTest', { | ||
| testCases: [ | ||
| new AwsCdkSdkJsStack(app, 'aws-cdk-sdk-js'), |
There was a problem hiding this comment.
Removing this since we are completely migrating off SDK v2.
Signed-off-by: Francis <colifran@amazon.com>
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-maintainer-review
colifran
approved these changes
Apr 25, 2024
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This was referenced Apr 26, 2024
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29937
Reason for this change
Adding assertions for
AwsCustomResourcewill improve our test coverage.Description of changes
Added assertions for
AwsCustomResourceto integ tests that were impacted by this PR.Description of how you validated changes
Assertions were validated by running the integ tests and verifying that it succeeded.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license