Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codecommit): kmsKey for repository #29988

Merged
merged 14 commits into from
Apr 30, 2024
Merged

Conversation

badmintoncryer
Copy link
Contributor

@badmintoncryer badmintoncryer commented Apr 27, 2024

Issue # (if applicable)

Closes #.

Reason for this change

Cloudformation supports for using customer managed kms key to encrypt data in codecommit repository but CDK doesn't support it.

Description of changes

Add kmsKey property to RepositoryProps.

Description of how you validated changes

Add both unit and integ tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 27, 2024 23:56
@github-actions github-actions bot added p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Apr 27, 2024
@badmintoncryer badmintoncryer changed the title feat(codebuild): use customer managed key for encrypting data in repository feat(codebuild): use a customer managed key to encrypt data in the repository Apr 27, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review April 28, 2024 00:21

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@badmintoncryer badmintoncryer changed the title feat(codebuild): use a customer managed key to encrypt data in the repository feat(codebuild): use a customer managed key to encrypt repository Apr 28, 2024
@badmintoncryer badmintoncryer marked this pull request as ready for review April 28, 2024 00:27
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 28, 2024
Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR title seems to be about a codebuild module, but it would be a codecommit.

Also, since this PR is not a change in processing but the addition of a new property, the PR title could be simpler: such as feat(codecommit): `kmsKey` for repository.

packages/aws-cdk-lib/aws-codecommit/README.md Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-codecommit/README.md Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-codecommit/README.md Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 28, 2024
@badmintoncryer badmintoncryer changed the title feat(codebuild): use a customer managed key to encrypt repository feat(codecommit): kmsKey for repository Apr 29, 2024
badmintoncryer and others added 5 commits April 29, 2024 09:22
Co-authored-by: k.goto <24818752+go-to-k@users.noreply.github.com>
Co-authored-by: k.goto <24818752+go-to-k@users.noreply.github.com>
@badmintoncryer
Copy link
Contributor Author

@go-to-k
Thank you for your review and I'm sorry for my mistakes. (Why codebuild...)
I've addressed your comments.

Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. LGTM.
That was a tough to the change of the integ test... :)

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 29, 2024
@badmintoncryer
Copy link
Contributor Author

@go-to-k Thank you very much! I got stuck with Git when trying to change file names from lowercase to uppercase.....😓

GavinZZ
GavinZZ previously approved these changes Apr 30, 2024
Copy link
Contributor

mergify bot commented Apr 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@GavinZZ
Copy link
Contributor

GavinZZ commented Apr 30, 2024

@mergify update

Copy link
Contributor

mergify bot commented Apr 30, 2024

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 30, 2024
@mergify mergify bot dismissed GavinZZ’s stale review April 30, 2024 18:49

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 862cd14
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Apr 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5f8e52e into aws:main Apr 30, 2024
14 checks passed
@badmintoncryer badmintoncryer deleted the codebuildKmsKey branch May 1, 2024 00:03
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants