-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(s3): update documentation for more context around autoDeleteObjects
#30096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
autoDeleteObjects
autoDeleteObjects
autoDeleteObjects
autoDeleteObjects
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
autoDeleteObjects
autoDeleteObjects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment. We need to give more context behind why the s3:PutBucketPolicy
is being added.
Updated the readme to provide more context around why the policy is being added. Please take a look when you get some time @colifran |
A few verbiage suggestions and then this will be good to go. |
Updated the docs, thanks @colifran |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
29873
Description of changes
This the documentation update to notify users that upon setting the
autoDeleteObjects
totrue
we would also add a new policys3:PutBucketPolicy
to handle race conditions.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license