Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-stepfunctions): refactor sagemaker tasks and fix default role issue #3014

Merged
merged 17 commits into from
Aug 21, 2019

Conversation

mattmcclean
Copy link
Contributor

  • Refactor the train job to create default security group and add new method to add new security groups
  • Ensure the environment variables and tags values are always string values
  • Change IAM role id to be different for SagemakerTrainJob and SagemakerTransformJob. Fixes aws-stepfunctions: issue with sagemaker tasks creating default roles #3013
  • Added new check to ensure there is an Image Name or Algorithm Name defined for the train job

Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license


@mattmcclean mattmcclean requested a review from a team as a code owner June 23, 2019 10:52
@mattmcclean mattmcclean changed the title fix(aws-stepfunctions) refactor and fix default role issue fix(aws-stepfunctions) refactor sagemaker tasks and fix default role issue Jun 23, 2019
@mattmcclean mattmcclean changed the title fix(aws-stepfunctions) refactor sagemaker tasks and fix default role issue fix(aws-stepfunctions): refactor sagemaker tasks and fix default role issue Jun 24, 2019
@mattmcclean
Copy link
Contributor Author

The error is due to a break in the compatibility as I removed the Construct param from the constructor of the SFN Task objects. This package should be flagged as experimental so that breaks in compatibility are allowed. Waiting for this change to be reflected in the CI process

@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 5, 2019

Triggering build

@mergify
Copy link
Contributor

mergify bot commented Aug 19, 2019

Pull Request Checklist

  • Testing
  • Unit test added (prefer to add a new test rather than modify existing tests)
  • CLI change? Re-run/add CLI integration tests
  • Documentation
  • Inline docs: make sure all public APIs are documented (copy & paste from official AWS docs)
  • README: update module README
  • Design: for significant features, follow the design process
  • Title uses the format type(scope): text
  • Type: fix, feat, refactor go into CHANGELOG, chore is hidden
  • Scope: name of the module without the aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
  • Style: use all lower-case, do not end with a period
  • Description
  • Rationale: describe rationale of change and approach taken
  • Issues: Indicate issues fixed via: fixes #xxx or closes #xxx
  • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Sensitive Modules (requires 2 PR approvers)
  • IAM document library (in @aws-cdk/aws-iam)
  • EC2 security groups and ACLs (in @aws-cdk/aws-ec2)
  • Grant APIs (if not based on official documentation with a reference)

@mergify
Copy link
Contributor

mergify bot commented Aug 19, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@rix0rrr rix0rrr added pr/do-not-merge This PR should not be merged at this time. and removed pr/do-not-merge This PR should not be merged at this time. labels Aug 21, 2019
@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit d8fcb50 into aws:master Aug 21, 2019
@mattmcclean mattmcclean deleted the sfn-sagemaker-fixes branch August 26, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-stepfunctions: issue with sagemaker tasks creating default roles
3 participants