-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ecs): let AsgCapacityProvider use IAutoScalingGroup only when Managed Termination Protection is disable #30335
Merged
Commits on May 24, 2024
-
Let AsgCapacityProvider use IAutoScalingGroup even when Managed Termi…
…nation Protection is enabled. The code will emit a warning message but will let the user specify a self managed ASG using `AutoScalingGroup.fromAutoScalingGroupName`. Also makes sure that when calling `Cluster.addAsgCapacityProvider`, the ASG used is not an imported one.
Configuration menu - View commit details
-
Copy full SHA for 1d78413 - Browse repository at this point
Copy the full SHA 1d78413View commit details
Commits on Jun 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 65aa924 - Browse repository at this point
Copy the full SHA 65aa924View commit details
Commits on Jun 20, 2024
-
fix(core): overrideLogicalId validation (aws#29708)
### Issue # (if applicable) Closes aws#29701 ### Reason for this change Calling `overrideLogicalId` on a `Construct` with an invalid logical ID ([docs](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/resources-section-structure.html#resources-section-structure-logicalid)) would not throw an error at synthesis time. CloudFormation would ### Description of changes * Validate `overrideLogicalId` (must not be empty, must not be over 255 characters, must match `/^[A-Za-z0-9]+$/` * Document exceptions with `@error` JSDoc tags ### Description of how you validated changes I've added unit tests, integration tests should not be necessary ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Configuration menu - View commit details
-
Copy full SHA for d0d05dd - Browse repository at this point
Copy the full SHA d0d05ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for d85ce7b - Browse repository at this point
Copy the full SHA d85ce7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bf9568 - Browse repository at this point
Copy the full SHA 1bf9568View commit details -
Configuration menu - View commit details
-
Copy full SHA for 197e8d8 - Browse repository at this point
Copy the full SHA 197e8d8View commit details
Commits on Jun 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e821362 - Browse repository at this point
Copy the full SHA e821362View commit details -
Co-authored-by: paulhcsun <47882901+paulhcsun@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 7fd9c3c - Browse repository at this point
Copy the full SHA 7fd9c3cView commit details
Commits on Jun 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 375dfb5 - Browse repository at this point
Copy the full SHA 375dfb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ff1c70 - Browse repository at this point
Copy the full SHA 1ff1c70View commit details -
Configuration menu - View commit details
-
Copy full SHA for d600661 - Browse repository at this point
Copy the full SHA d600661View commit details
Commits on Jun 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d7d6b58 - Browse repository at this point
Copy the full SHA d7d6b58View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.