feat(codedeploy): zonal configuration for ServerDeploymentConfig
#30429
Conversation
github-actions
bot
added
p2
distinguished-contributor
github-actions
bot
added
the
feature-request
aws-cdk-automation
added
the
pr/needs-community-review
aws-cdk-automation
removed
the
pr/needs-community-review
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
badmintoncryer
force-pushed
the
zonalConfig
branch
from
5f52cde
to
86d2a99
Compare
|
@lpizzinidev Thank you for your review! I've addressed your comments. |
|
@paulhcsun Thank you for your review!! I've addressed your comments. |
packages/aws-cdk-lib/aws-codedeploy/lib/base-deployment-config.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Nice work @badmintoncryer! I've approved the PR but added a do-not-merge label as we're currently holding off on merging anything while fixing a custom resources related issue which touches a lot of integ tests. This change probably would not affect that but we're pausing all merges temporarily to be safe. We should hopefully be able to get this merged in tomorrow if not sometime next week. Thanks for your patience and understanding! 🙏
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@mergify update |
✅ Branch has been successfully updated |
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
@paulhcsun I've updated snapshots. So, could you please review this again? |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…30429) ### Issue # (if applicable) Closes #30430 ### Reason for this change `ServerDeploymentConfig` does not support for configuring the [zonal configuration](https://docs.aws.amazon.com/codedeploy/latest/userguide/deployment-configurations-create.html#zonal-config). ### Description of changes - define `ZonalConfig` interface - define `MinimumHealthyHostsPerZone` class - add `zonalConfig` property to the `BaseDeploymentConfigProps` ### Description of how you validated changes Add both unit and integ tests ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
Closes #30430
Reason for this change
ServerDeploymentConfigdoes not support for configuring the zonal configuration.Description of changes
ZonalConfiginterfaceMinimumHealthyHostsPerZoneclasszonalConfigproperty to theBaseDeploymentConfigPropsDescription of how you validated changes
Add both unit and integ tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license