fix(event-targets): ecsTask uses invalid task definition arn in policy

[jwoehrle]

Issue # (if applicable)

Closes #30390

Reason for this change

Missing wildcard for imported task definition without revision in iam policystatement resource

Description of changes

In case of an imported task definition (ARN is not an unresolved Token) and there is no revision add :* to resource of policystatement

Description of how you validated changes

Added unit tests.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[paulhcsun]

Hi @jwoehrle, thank you for the contribution! Would you be able to add some new integration tests and update the integration snapshots by running yarn integ --update-on-failed?

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: eba0eb7
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[aws-cdk-automation]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[jwoehrle]

@paulhcsun
I'd be happy to add an integration test... However, I struggle with creating a TaskDefinition first and then later import it via the fromFargateTaskDefinitionAttributes. Can you point me into the right direction on how to basically deploy two stacks and use the string value of the arn of the first stack's TaskDefinition in the second stack? I need the actual string representation, not a CfnOutput which would be result in an Fn:ImportValue in the second stack

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

[paulhcsun]

hi @jwoehrle, apologies for the delay in my response, I've been out for the past couple weeks. You can create an integ test that contains two stacks and define resources separately for these stacks. I believe it is documented somewhere but I'm having some trouble finding it so I'll check with the team, however this integ test can be used as a reference for how to set that up: https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-with-replication.ts

[moelasmar]

mark this pr to request changes as requested by @paulhcsun

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

[aws-cdk-automation]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.