Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(msk-alpha): support any combination of client auth mechanisms #30504

Closed
wants to merge 6 commits into from

Conversation

vdahlberg
Copy link

@vdahlberg vdahlberg commented Jun 10, 2024

Issue

Closes #28592
Related #22041
Related PR #30307

Reason for this change

MSK clusters should allow any combination of authentication methods as stated for example here.

Description of changes

  • Allow any combination of authentication modes
  • Change the LogicalId of the bootstrapbroker custom resource since it doesn't really make sense that the first used auth method is used if you have multiple auth methods. This is a behavior change but not breaking, as far as I can tell.
  • I did run integrationtests but commit a899ac6 introduced conflicts - and unfortunately I am not able to rerun the integration test. Need help from a maintainer.

Description of how you validated changes

  • unit tests
  • integration tests
  • deploying a small sample stack and "upgrading" it (changing the logical id of the bootstrap broker custom resource)

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jun 10, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team June 10, 2024 06:11
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@vdahlberg vdahlberg changed the title Feat/msk multiple auth fix(msk-alpha): support any combination of client auth mechanisms Jun 10, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f8f4783
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Jul 10, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-msk-alpha: should support multiple auth modes
2 participants